[Twisted-Python] Review of kqueue reactor patch (ticket 1918)

Glyph glyph at twistedmatrix.com
Fri Jan 13 22:59:27 EST 2012

On Jan 13, 2012, at 6:20 AM, Tobias Oberstein wrote:

> Hi all,
> the latest patch contained in
> http://twistedmatrix.com/trac/ticket/1918
> is - after some iterations - now in a "ready for final review state" for some weeks now.
> I'd like to ask if someone has time to review it so it can be finally merged and the issue closed .. after 6 years;)
> Cheers,
> Tobias 

Hi Tobias,

I, too, would like to see this reviewed, and I hope I will find some time to do it myself.  (Actually I really hope that someone else will find the time to do it before that, but, failing that...)

However, our reviewer bandwidth has recently decreased somewhat, as you can see from a quick comparison between <http://twistedmatrix.com/highscores/> and <http://twistedmatrix.com/highscores/?time=2011-12-01>.

The best way to get your tickets reviewed is to pitch in and do some code reviews of other tickets in the meanwhile, so the hypothetical perfectly stochastic Twisted ticket reviewer will be more likely to select your ticket from the list available on <http://twistedmatrix.com/trac/report/15>.

Not that I in any way object to your agitating for a review of this specific ticket, though: people should feel free to do that as well.  If anything, consider this a bump, to keep this at the front of everyone else's mind.

Now: somebody, go review that ticket :).


More information about the Twisted-Python mailing list