No subject


Sun Apr 26 08:47:01 EDT 2009


me, but  I'll start taking a look at it in more detail, and see what I can
come up with.  Might need some more tests, etc.

Kevin "Someone" Horn

--000e0cd66c320b268804753493ba
Content-Type: text/html; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable

<div class=3D"gmail_quote">On Mon, Oct 5, 2009 at 1:32 PM, Glyph Lefkowitz =
<span dir=3D"ltr">&lt;<a href=3D"mailto:glyph at twistedmatrix.com">glyph at twis=
tedmatrix.com</a>&gt;</span> wrote:<br><blockquote class=3D"gmail_quote" st=
yle=3D"border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex=
; padding-left: 1ex;">
<div class=3D"gmail_quote"><div class=3D"im">On Mon, Oct 5, 2009 at 12:34 P=
M, Kevin Horn <span dir=3D"ltr">&lt;<a href=3D"mailto:kevin.horn at gmail.com"=
 target=3D"_blank">kevin.horn at gmail.com</a>&gt;</span> wrote:<br><blockquot=
e class=3D"gmail_quote" style=3D"border-left: 1px solid rgb(204, 204, 204);=
 margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">

I&#39;d like to see this ticket get moving again.</blockquote></div><div><b=
r>Excellent!<br>=A0</div><div class=3D"im"><blockquote class=3D"gmail_quote=
" style=3D"border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0=
.8ex; padding-left: 1ex;">

I&#39;ve gone over what&#39;s been done so far (and put my comments in the =
ticket), and it looks like everything is at least mostly ready to be merged=
 into the Twisted trunk.<br></blockquote></div><div><br>Your analysis on th=
e ticket looks fairly thorough.<br>
</div></div></blockquote><div><br>Thanks!=A0 Though, really I just went ove=
r the changesets that therve submitted, and checked them against exarkun&#3=
9;s suggestions.<br>=A0</div><blockquote class=3D"gmail_quote" style=3D"bor=
der-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-=
left: 1ex;">
<div class=3D"gmail_quote"><div>
=A0</div><div class=3D"im"><blockquote class=3D"gmail_quote" style=3D"borde=
r-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-le=
ft: 1ex;">So what else needs to be done to get this to happen?=A0 I&#39;m h=
appy to try and get it done, but a little direction would be really handy. =
;)<font color=3D"#888888"><br>

</font></blockquote></div><div><br>The workflow is pretty simple.<br><ol><l=
i>author submits change<br></li><li>reviewer reviews change</li><li>someone=
 responds to feedback</li><li>&quot;someone&quot; becomes &quot;author&quot=
;, repeat</li>

</ol>Right now we&#39;re stuck in the middle of step 3, but given that ther=
ve does not appear to be actively working on this branch, the path forward =
is clear.=A0 <i>You</i> become &quot;someone&quot;, and submit a patch that=
 finishes dealing with the issues that you have mentioned as not already ta=
ken care of by therve&#39;s subsequent changesets.=A0 The best way to do th=
is is to submit a patch against the branch, rather than against trunk.=A0 G=
iven such a patch, a twisted committer can then apply the patch to the bran=
ch and submit to buildbots (etc) as appropriate.=A0 By submitting it agains=
t the branch, you make it easy for the reviewer to examine the changes you&=
#39;re submitting in isolation from the rest of the larger change, to see i=
f they address the points that you&#39;ve brought up.<br>

<br>If the reviewer is happy with your changes, then the patch + branch wil=
l be immediately merged to trunk; of course, the next review might have a l=
ittle more feedback for you to deal with ;).<br><br>Thanks for your interes=
t!<br>

</div></div>
<br></blockquote><div>=A0</div><div>That&#39;s kind of what I figured.=A0 <=
br><br>From my previous review of the current status, it looks pretty well =
done to me, but=A0 I&#39;ll start taking a look at it in more detail, and s=
ee what I can come up with.=A0 Might need some more tests, etc.<br>
<br>Kevin &quot;Someone&quot; Horn<br><br>=A0<br></div></div>

--000e0cd66c320b268804753493ba--



More information about the Twisted-Python mailing list