[Twisted-Python] A Python metaclass for Twisted allowing __init__ to return a Deferred
terry at jon.es
Mon Nov 3 10:56:58 EST 2008
[I'm replying the original because I want to comment on comments by all of
JP, Esteve and Glyph]
Glyph - I appreciate your comments on testing, and agree that's
problematic. I also like your pattern, have run into it myself, and will
use it - thanks.
Glyph also said I didn't really provide a use-case, so I'll do that a bit
more clearly now. That leads me back in the direction of preferring my
from my.project.code import database
def __init__(self, tableName, tableSpec, dbURI):
self.db = db
d = database.getDB(dbURI)
d.addCallback(self.createDBTable, tableName, tableSpec)
def _createDBTable(self, txn, tableName, tableSpec):
txn.execute('CREATE TABLE %s(%s)' % (tableName, tableSpec))
def createDBTable(self, result, tableName, tableSpec):
assert result is None
Here database.getDB returns a Deferred, as does self.createDBTable.
The problem with approaches that don't actually create the class instance,
is that __init__ is calling self.createDBTable, but self doesn't exist
yet. So putting code to deal with Deferreds into __new__ wont help unless
that code has nothing to do with the instance of the class.
But using a metaclass makes it really easy. You just write your code
completely as usual, using whatever Twisted/Deferred calls you want
(including digging around in self), and return the Deferred result. You can
wrap your __init__ in inlineCallbacks if you like.
The difference is that my metaclass approach does create an instanced of
the class. It just moves __init__ out of the way (into the __hidden__ dict,
along with the args and kwargs) and calls it when you call __instantiate__.
So I find the metaclass approach more general, though of course I don't
like the clutter of __hidden__ or __instantiate__.
With JP's suggestion of cleaning up the return result of __instantiate__ to
just return the instance, I think it's a pretty clean solution - from the
POV of the caller. You just act as normal in writing your class, but stick
in a __metaclass__. Then calling gets you a Deferred, which is perfectly
normal in the Twisted world.
I guess what you should do depends on how complex your situation is, and
also on whether you've already written your class code when you realize you
need __init__ to somehow deal with Deferreds (in which case it may be
easier to just add __metaclass__).
If you do have the simpler situation, in which the Deferred is coming from
the outside world (i.e., not from calling methods on self), then Glyph's
approach is probably the nicest (the following is untested):
def __init__(self, *args, dResult=None, **kw):
# do something
def fromDeferred(cls, d, *args, **kw):
return cls(*args, dResult=result, **kw)
Which lets you create an object directly (no deferred involved), lets you
create it after a deferred fires, and also lets you directly send in a fake
More information about the Twisted-Python