[Twisted-Python] Ticket Hall of Shame - Current Loser: Brian Warner

Thomas Jacob jacob at internet24.de
Fri Jan 12 11:51:36 EST 2007

On Fri, 2007-01-12 at 11:15 -0500, Christopher Armstrong wrote:

> This idea is contradictory with your proposal.  If we do not require
> unit tests for all changes, then we *cannot* rely on the existing unit
> tests to tell us when new changes break the code.

Sure you can, you can check whether they break the old read already
unit tests which were written with the "intended" functionality
of a particular module in mind when the module was first created.

Requiring people that submit patches that actually change or extend said
functionality to also include unit testing code is perfectly fine.

But bug fixes that fix something which is somehow clearly
(in the responsible developer's view) intended functionality 
that is nevertheless not yet covered by an existing test
(obviously not ;) are a different matter...

Expecting twisted users that find such problems in Twisted to also
submit functional unit test is placing the hurdle
for bug fixes that get added to twisted quite high.

The idea of course is that later the Twisted developer
responsible for the module in question extends the unit
tests for that module's core functionality to also
include the bug fix case if they feel the need and/or
have the time.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 191 bytes
Desc: This is a digitally signed message part
Url : http://twistedmatrix.com/pipermail/twisted-python/attachments/20070112/4c219842/attachment.pgp 

More information about the Twisted-Python mailing list