[Twisted-Python] removing unsupported reactors in twisted 2.6: qt,

glyph at divmod.com glyph at divmod.com
Mon Sep 25 00:28:11 EDT 2006


On Mon, 25 Sep 2006 01:17:14 -0300, David Pratt <fairwinds at eastlink.ca> wrote:
>Hi all. I am also using the threadedselectreactor in wx without problems. I 
>have only just read these posts and cannot understand any reasoning to drop 
>it. What am I missing?

"If it's not tested, it's broken."

The point is not that I want to drop this code from Twisted.  In fact, far from it, I would like Twisted to support as many toolkits as possible.

The point is that these reactors are currently excluded from automated test coverage, and have no maintainers.  That means that they do not currently work as well as the other reactors, but more seriously, if they were to be *completely* broken (say, start raising exceptions upon import), nobody on the Twisted team would know until users started complaining, and most likely users would not complain until well after we had already produced a broken release.

We could add automated test coverage relatively easily, *IF* someone would volunteer to at least look at the results of that coverage and contribute some fixes.  Perhaps you were not even aware that there are reliability problems with threadedselectreactor.  To see an example of the problem, run "trial --reactor threadedselect twisted".

Would you volunteer to have a look at some of these problems and try to fix them?  I have no idea how many people are using Twisted in conjunction with wxwindows today, but you would be a hero to all of them, I'm sure :).




More information about the Twisted-Python mailing list