Branch based development (Was Re: [Twisted-Python] Re: [Twisted-commits] r16287 - Revert r16241; tests are passing.)
exarkun at divmod.com
Thu Mar 23 13:39:07 EST 2006
On Fri, 24 Mar 2006 05:29:08 +1100, Andrew Bennetts <andrew-twisted at puzzling.org> wrote:
>glyph at divmod.com wrote:
>> It's also worth noting that if code fails the buildbot after review (or
>> lacks adequate tests and thereby breaks critical existing functionality),
>> it's the reviewer's fault, not the author's! Therefore, it is suggested
>> that you make heavy use of buildbot's "build this branch" feature before
>> OKing a merge.
>Or, more likely, is a pre-existing intermittent failure. :P
Everyone who commits to Twisted should be familiar with the intermittent test failures present in the suite. For anyone who isn't, I recommend you spend some time looking at the buildbot waterfall before making any further commits.
More information about the Twisted-Python