[Twisted-Python] Re: [Twisted-commits] r16287 - Revert r16241; tests are passing.

Jean-Paul Calderone exarkun at divmod.com
Tue Mar 14 11:14:18 EST 2006


On Mon, 13 Mar 2006 12:33:30 -0700, Wilfredo Sanchez <wsanchez at wolfwood.twistedmatrix.com> wrote:
>Author: wsanchez
>Date: Mon Mar 13 12:33:27 2006
>New Revision: 16287
>
>Modified:
>   trunk/twisted/web2/dav/acl.py
>   trunk/twisted/web2/dav/element/base.py
>   trunk/twisted/web2/dav/element/rfc3744.py
>   trunk/twisted/web2/dav/http.py
>   trunk/twisted/web2/dav/idav.py
>   trunk/twisted/web2/dav/method/propfind.py
>   trunk/twisted/web2/dav/resource.py
>   trunk/twisted/web2/dav/static.py
>Log:
>Revert r16241; tests are passing.

This does not actually appear to be the case.  The quick build which ran as a result of this commit had these results:

Running 2 tests.
twisted.web2.dav.test.test_prop.PROP.test_PROPFIND ... [OK]
twisted.web2.dav.test.test_prop.PROP.test_PROPFIND ... [ERROR]

===============================================================================
[ERROR]: twisted.web2.dav.test.test_prop.PROP.test_PROPFIND

  File "/home/buildbot/BuildBot/slave/quick/Twisted/twisted/web2/dav/http.py", line 287, in statusForFailure
    failure.raiseException()
  File "/home/buildbot/BuildBot/slave/quick/Twisted/twisted/web2/dav/method/propfind.py", line 119, in gotXML
    properties_by_status[responsecode.OK].append(resource.readProperty(property, request))
  File "/home/buildbot/BuildBot/slave/quick/Twisted/twisted/web2/dav/resource.py", line 129, in readProperty
    return davxml.GETContentLength(self.contentLength())
  File "/home/buildbot/BuildBot/slave/quick/Twisted/twisted/web2/dav/element/base.py", line 107, in __init__
    assert isinstance(child, (WebDAVElement, PCDATAElement)), "Not an element: %r" % (child,)
exceptions.AssertionError: Not an element: 2717L
-------------------------------------------------------------------------------
Ran 2 tests in 0.371s

FAILED (errors=1, successes=1)

This is slightly challenging to reproduce due to the fact that "trial -u twisted.web2.dav" crashes horribly after the first run.

Jean-Paul




More information about the Twisted-Python mailing list