[Twisted-Python] Re: [Twisted-commits] r15739 - Add TodoTest; peer to SkipTest

[Jean-Paul Calderone]

On Wed, 25 Jan 2006 16:32:57 -0700, Wilfredo Sanchez <wsanchez at wolfwood.twistedmatrix.com> wrote:
>Author: wsanchez
>Date: Wed Jan 25 16:32:56 2006
>New Revision: 15739
>
>Modified:
>   trunk/twisted/trial/unittest.py
>Log:
>Add TodoTest; peer to SkipTest
>
> [snip]
>@@ -467,8 +483,9 @@
>         if len(f.value.args) > 0:
>             reason = f.value.args[0]
>         else:
>-            warnings.warn(("Do not raise unittest.SkipTest with no "
>-                           "arguments! Give a reason for skipping tests!"),
>+            warnings.warn(("Do not raise unittest.SkipTest or "
>+                           "unittest.TodoTest with no arguments! Give a reason "
>+                           "for skipping tests!"),
>                           stacklevel=2)
>             reason = f
>         return reason

There's no reason to allow no arguments for this new feature.  The warning is in place for SkipTest because at one point it was allowed to raise a SkipTest with no reason, but this was never the case for TodoTest.

Jean-Paul