[Twisted-Python] NAPTR and some dns.py import issue
exarkun at divmod.com
Fri Dec 8 21:50:18 EST 2006
On Fri, 8 Dec 2006 18:05:53 -0800 (PST), Andy Leszczynski <leszczynscy at yahoo.com> wrote:
>There was a recent discussion: FWIW - I have a patch to dns.py with NAPTR implemented but it is a very hackish solution: I mean it serves very specific application and works fine and basis are there.
>I also faced the issue with the twisted/names/dns.py - specifically with "from twisted.python import components". Since I did not want to overwrite the twisted/names/dns.py, I just took it, renamed and applied NAPTR patch, saved in my app directory and import it now under new name. Surprisingly it did want to import so in order to fix the problem I had to replace "from twisted.python import components" with "from zope.interface import interface" and
I'm not sure I understand this issue. There haven't been any imports of
twisted.python.components in twisted.names.dns in some time. If you're
going to work on a patch to contribute, it would be best to do it based
on current trunk at HEAD, so that you don't end up writing anything which
will conflict with changes which have already been made.
>This is what I have - I would be interested in Twisted supporting NAPTR - let me know if I can participate.
I'd certainly be interested to see what you have. I don't really have any
driving need for NAPTR support in Twisted myself, though, so it's mostly an
academic interest. Still, if the functionality works, it comes with good
test coverage, and conforms to the coding standard, there's no reason at all
it shouldn't be added to Twisted.
So, I welcome any contribution you would be willing to make. :)
More information about the Twisted-Python