[Twisted-Python] svn-reorg blocking

Jonathan Lange jml at mumak.net
Wed Oct 26 00:10:04 EDT 2005

On 26/10/05, glyph at divmod.com <glyph at divmod.com> wrote:
> >On 10/26/05, James Y Knight wrote <foom at fuhm.net> wrote:
> >The way I see it is that you put a horrible hack in trial to work
> >around a problem that wouldn't happen if the code actually followed
> >Twisted's coding convention.
> In James' defense, Twisted's coding standard actually says what serialport is doing is OK.  The portion of the standard that says this is my work, and I think the coding standard should be changed, because this is an awful hack, but one thing that can't be said about it is that it isn't officially endorsed :).
> I tend to agree with your general sentiment but I don't think that this issue is important enough to hold up the re-org.  James has implemented a solution.  Let's just use it.

I strongly and vigorously oppose merging this branch until there are
unit tests for James' modifications to Trial.  Instead I recommend
moving serialport up a level (as you suggested earlier).  That appears
to be the simplest thing that could possibly work.


More information about the Twisted-Python mailing list