[Twisted-Python] why tests are failing with the gtk2 reactor + oldtrial but passing with newtrial
Jonathan Simms
slyphon at twistedmatrix.com
Mon Oct 18 13:59:44 EDT 2004
Glyph Lefkowitz wrote:
>On Mon, 2004-10-18 at 02:52, Jonathan Simms wrote:
>
>
>
>>In the end, it was a VERY GOOD THING that JP demanded that I revert the
>>merge of my branch, as
>>the reactor-installation code was flawed.
>>
>>
>
>I am a little confused - the first half of your message makes sense to
>me, and this makes sense to me, but they do not seem to be connected in
>any way. How was the reactor-installation code flawed?
>
>
>
>
Heh, well, to be perfectly honest, the only connection between these two
things was that it
was through debugging one that I discovered the other. Basically, the
reactor installation code
was flawed because the reactor installation code was somehow factored
out, while the option
was left in, so no matter what you specified with --reactor, you got the
select reactor.
The reason the select reactor was getting installed was that the
trial.util class was a top-level
import, and it had twisted.internet.reactor as a top-level import.
This is all fixed and tested for now.
-Jonathan
More information about the Twisted-Python
mailing list