[Twisted-Python] Re: [Twisted-commits] r12418 - survive a re-entrant call to .resumeProducing, which happens under the cf

Andrew Bennetts andrew-twisted at puzzling.org
Mon Nov 8 23:01:38 EST 2004


On Mon, Nov 08, 2004 at 10:15:32PM -0500, James Y Knight wrote:
> On Nov 8, 2004, at 9:06 PM, Brian Warner wrote:
> >Modified:
> >   trunk/twisted/web/static.py
> >Log:
> >survive a re-entrant call to .resumeProducing, which happens under the 
> >cf
> >reactor
> 
> Ew ew ew ew! That's just broken, reactors *really* shouldn't do that. I 
> am pretty sure no resumeProducing implementations expect to be called 
> again in response to their own write(), nor should they have to.

How about writing (and committing) a test case? ;)

-Andrew.





More information about the Twisted-Python mailing list