[Twisted-Python] [PATCH] HTTP server fix for the FD problem

Glyph Lefkowitz glyph at twistedmatrix.com
Sun May 11 09:22:19 EDT 2003


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1


On Sunday, May 11, 2003, at 04:28 AM, Andrew Bennetts wrote:

> I'm a little concerned that I'm being a touch to evil, though:
>
> -class HTTPChannel(basic.LineReceiver):
> +class HTTPChannel(policies.TimeoutWrapper(basic.LineReceiver)):

Yow... yes.

I like the fact that your code is generic, but can you modify it to be 
applied at "run-time" rather than at "compile-time"?  It seems to me 
like it would be easier to tweak if we did that.  (Say, modify the 
buildProtocol method of HTTPFactory...)

HTTP may be enough of a special case that Moshe's patch is a good idea. 
  Could this code be re-used for, say, IRC?
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.1 (Darwin)

iD8DBQE+vk6PvVGR4uSOE2wRAl8DAKCdHV81wkVfr8FczoEebFqES2FFVgCgqHEZ
WkFQD49s8Jpd9DwyCUy5TtY=
=dcLl
-----END PGP SIGNATURE-----





More information about the Twisted-Python mailing list