[Twisted-Python] ReverseProxy doesn't send X-Forwarded-For header

Moshe Zadka m at moshez.org
Tue Jun 3 00:48:02 EDT 2003

On Mon, 2 Jun 2003, Itamar Shtull-Trauring <itamar at itamarst.org> wrote:

> Done. Thanks!

I have reverted this patch, for the following reasons:

1. It removes functionality: there is no way for subclasses to avoid sending
   this header, while it is easy, the way the code is now, for a subclass
   to add this header if it so wishes.

2. It divulges private information (the client's IP) to possibly hostile

If you really want this, just do it in a custom subclass.
Moshe Zadka -- http://moshez.org/
Buffy: I don't like you hanging out with someone that... short.
Riley: Yeah, a lot of young people nowadays are experimenting with shortness.
Agile Programming Language -- http://www.python.org/

More information about the Twisted-Python mailing list