[Twisted-Python] Re: Fixes for windows installer

Cory Dodt corydodt at yahoo.com
Fri Feb 28 13:53:06 EST 2003

I like where this is going, and I certainly have no complaints about
dumping shortcut.py, but could you please review a few things before I
commit this:

* Putting install-script into setup.cfg makes your change visible to
everyone who's building a distribution of Twisted.  As you pointed out
yourself, you can't use install-script without distutils 1.0.3, and
Twisted has to support pythons 2.1 and 2.2.  Will this config parameter be
ignored by setup.py when building a Twisted install on distutils <1.0.3 or
will it cause an error?

* You made this change to the test I use for isWinNT:
-    if platform.isWinNT():
-        return os.path.join(os.getenv("SYSTEMROOT"), 
-                            "system32", "shell32.dll")
+    # If SYSTEMROOT is not found (on Win98), guess the name
+    # of the windows directory
+    isNT = 0
+    try:
+        get_special_folder_path("CSIDL_COMMON_PROGRAMS")
+        isNT = 1
+    except OSError: # probably Win98
+        pass

Is the implementation of platform.isWinNT() broken?  If so, I'd rather you
patched it there.  If not, I'd rather keep using it.

* Most important thing: test_postinstall doesn't work with this patch,
because create_shortcut and get_special_folder_path appear to be magical
builtins installed by distutils.  I'll be happy to rewrite the test if you
can point me to the right place to import this code when it's not
available as a builtin.

Do you Yahoo!?
Yahoo! Tax Center - forms, calculators, tips, more

More information about the Twisted-Python mailing list