[Twisted-Python] SMTP client patch
glyph at twistedmatrix.com
Thu Feb 20 17:14:31 EST 2003
-----BEGIN PGP SIGNED MESSAGE-----
On Thursday, February 20, 2003, at 08:11 AM, Anders Hammarquist wrote:
> A while ago I posted a patch for the client part of t.p.smtp, but I
> haven't heard any comments. Did it get lost, or is everyone just
> busy with more interesting projects?
A little of both, I think :)
I had a look at this patch with Itamar today. We like where you're
going, but here are a few issues:
1. it's not backwards compatible. DocmaServer uses its own sendEmail,
which depends on the sentEmail callback's signature.
I personally would like to see Twisted's sendEmail deprecated and
replaced with an admonishment to use the 'email' module ;), so it would
be nice if you could re-implement sendEmail in terms of your MIME-less
2. Those change to LineReceiver made no sense to us. Care to explain?
3. What's up with the SMTP logger? and logging every line in the
client? This is duplicated generic code, and should probably be
refactored into someplace more appropriate, like twisted.python.log.
This is just from a cursory look-over; the main issue is #1. Thanks
for the patch!
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.1 (Darwin)
-----END PGP SIGNATURE-----
More information about the Twisted-Python