[Twisted-Python] c++ style comments in c extension modules

Bob Ippolito bob at mastersofbranding.com
Thu Apr 17 16:43:10 EDT 2003


On Thursday, Apr 17, 2003, at 16:19 America/New_York, Jon Dyte wrote:

> When building twisted 1.0.3 on solaris using the sun 'cc' compiler, 
> several of the c extension modules fail because
> of the prescence of '//' for a comment in the code.
>
> grep -n "\/\/" `find . -name "*.c" -print`
>
> ./twisted/internet/cReactor/cDelayedCall.c:126:    // self.time += 
> secondsLater
> ./twisted/internet/cReactor/cDelayedCall.c:170:    // self.time = 
> time() + secondsFromNow
> ./twisted/internet/cReactor/cReactorTCP.c:159:    char 
> buf[3*20+3+1+100]; // for good measure
> ./twisted/internet/cReactor/cReactorTime.c:93:        return NULL; // 
> TODO: set exception?
> ./twisted/internet/cReactor/cReactorTime.c:125:    //return 
> cDelayedCall_cancel(call, NULL);
>
> please can these be replaced with the /* */ to keep the compiler happy?
> I'd fix it myself but dont have CVS access.
>
> I think the gnu compiler is more forgiving, unfortunately solaris cc 
> is not.

Well, as far as I know, cReactor doesn't really work yet.. and the 
other C extensions don't exhibit this issue.  I'm sure it'll get fixed 
by the time cReactor is actually supposed to work, though :)

-bob





More information about the Twisted-Python mailing list