[Twisted-Python] Re: Addition to twisted.python.logfile

Itamar Shtull-Trauring twisted at itamarst.org
Fri Oct 18 10:53:59 EDT 2002

On 18 Oct 2002 11:52:36 -0000
Moshe Zadka <twisted at moshez.org> wrote:

> 2. In general, you should submit patches from inside the CVS working
>    copy, not from the installed version

Yeah - but in this case it's fine.

> 3. As I read your patch, this means that a Twisted server would be
>    unresponsive for 6 seconds while it is compressing. This is, in
>    general, unacceptable.

Yes, we're going to have to use a thread for this - would you care to do
it John? If not I'll hang on to your patch and use it as a basis when I
get around to it.

> 4. Perhaps it would be better to use the "gzip" program, via the
> process
>    API. A simple way to hook into logfile.py so we could add a hook to
>    utils.getProcessValue("/usr/bin/gzip", args=[old_name]) would seem
>    simpler and possibly even more efficient.

And wouldn't work on Windows... The question is if we care about
compresssing logs on Windows. I think we should.

> 5. Perhaps the correct thing to do is make Logfile subclassable enough
> so
>    a compressing Logfile could be written as a subclass. 

I was thinking this at first, but in practice I don't see if there's
much point. What would it give us?

Itamar Shtull-Trauring    http://itamarst.org/
Available for Python, Twisted, Zope and Java consulting

More information about the Twisted-Python mailing list