[Twisted-Python] Re: [Twisted-commits] fixed a docstring typo in twisted.internet.tcp (callse -> calls, or something like that)

Bob Ippolito bob at redivi.com
Sat Dec 28 18:45:06 EST 2002


On Saturday, Dec 28, 2002, at 17:48 America/New_York, Itamar 
Shtull-Trauring wrote:

> On Fri, 27 Dec 2002 21:23:10 -0600
> etrepum CVS <etrepum at twistedmatrix.com> wrote:
>
>>          # Send as much data as you can.
>>          l = self.writeSomeData(self.unsent)
>> -        if l < 0:
>> +        if l < 0 or isinstance(l, Exception):
>>              return l
>>          if l == 0 and self.unsent:
>>              result = 0
>
>
> Hmmmm... I'm not sure if writeSomeData is ever supposed to return an
> exception. Who was returning what?
>

Well, at a glance.. twisted.internet.process.ProcessWriter, 
twisted.internet.process.PTYProcess, and 
twisted.internet.tcp.Connection can return main.CONNECTION_LOST (an 
Exception), or an integer >= 0





More information about the Twisted-Python mailing list