[Twisted-Python] Problems with bdist_rpm on 0.11.0

Jeff Epler jepler at inetnebr.com
Tue Oct 9 15:06:37 EDT 2001

I had problems building 0.11.0 with "python2 setup.py bdist_rpm" on my
system.  (redhat 6.2, python 2.1 rpm from tummy)

There were two syntax errors in twisted/mail/pb.py, and
twisted/spread/cBanana.c was not being included in the tarball that
bdist_rpm build (I think this is equivalent to 'python2 setup.py sdist',
if non-rpm folks want to see the problem).

This patch fixes the syntax errors (missing close parens), and adds
cBanana.c to MANIFEST.in.  I'm not sure that this is the correct fix
for the extension, but It Works For Me(tm)

Please copy me (jepler at inetnebr.com) on any discussion.

-------------- next part --------------
diff -ru Twisted-0.11.0/MANIFEST.in Twisted-0.11.0-local/MANIFEST.in
--- Twisted-0.11.0/MANIFEST.in	Sun Aug 19 00:15:23 2001
+++ Twisted-0.11.0-local/MANIFEST.in	Mon Oct  8 11:22:26 2001
@@ -22,6 +22,7 @@
 include MANIFEST.in
+include twisted/spread/cBanana.c
 recursive-include bin *
 recursive-include doc *.html
diff -ru Twisted-0.11.0/twisted/mail/pb.py Twisted-0.11.0-local/twisted/mail/pb.py
--- Twisted-0.11.0/twisted/mail/pb.py	Wed Sep 26 04:00:25 2001
+++ Twisted-0.11.0-local/twisted/mail/pb.py	Mon Oct  8 11:26:56 2001
@@ -26,7 +26,7 @@
     def getFolderMessage(self, folder, name):
         if '/' in name:
             raise IOError("can only open files in '%s' directory'" % folder)
-        fp = open(os.path.join(self.directory, 'new', name)
+        fp = open(os.path.join(self.directory, 'new', name))
             return fp.read()
@@ -78,7 +78,7 @@
     def _isSubFolder(self, name):
         return (not os.path.isdir(os.path.join(self.rootDirectory, name)) or
                 not os.path.isfile(os.path.join(self.rootDirectory, name, 
-                                                'maildirfolder'))
+                                                'maildirfolder')))
 class MaildirCollection(pb.Referencable):

More information about the Twisted-Python mailing list